Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence spammy blueprint warnings and validate blueprint on load #4303

Merged
merged 5 commits into from Nov 22, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Nov 21, 2023

What

Adding a helper to silence the error messages only solved half the problem. Nothing prevented this corrupt data from being removed from the store, and worse, in some cases the corrupt data subsequently prevented new writes.

We now validate that all the data in the blueprint has a valid schema or else we refuse to load it.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 🟦 blueprint The data that defines our UI include in changelog labels Nov 21, 2023
@jleibs jleibs marked this pull request as ready for review November 21, 2023 21:58
@teh-cmc teh-cmc self-requested a review November 22, 2023 07:39
crates/re_viewer/src/blueprint_validation.rs Outdated Show resolved Hide resolved
@jleibs jleibs merged commit c4126cf into main Nov 22, 2023
39 checks passed
@jleibs jleibs deleted the jleibs/blueprint_validation branch November 22, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deserialization log spam when trying to load old blueprint
2 participants