Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot legend visibility and position control (part 3): legend UI added for both timeseries and bar charts space views #4365

Merged
merged 2 commits into from Nov 28, 2023

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Nov 28, 2023

What

Introduce UI controls to set the legend visibility and location for both timeseries and bar chart space views

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Nov 28, 2023
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@abey79 abey79 force-pushed the antoine/timeseries-legend-part-2 branch from e4e8db0 to e082a08 Compare November 28, 2023 16:09
@abey79 abey79 force-pushed the antoine/timeseries-legend-part-3 branch from af57401 to f6a2ac2 Compare November 28, 2023 16:09
Base automatically changed from antoine/timeseries-legend-part-2 to main November 28, 2023 16:28
@abey79 abey79 force-pushed the antoine/timeseries-legend-part-3 branch from f6a2ac2 to 071a456 Compare November 28, 2023 16:30
@abey79 abey79 merged commit 95efb76 into main Nov 28, 2023
39 checks passed
@abey79 abey79 deleted the antoine/timeseries-legend-part-3 branch November 28, 2023 16:58
teh-cmc pushed a commit that referenced this pull request Nov 30, 2023
… for both timeseries and bar charts space views (#4365)

### What

Introduce UI controls to set the legend visibility and location for both
timeseries and bar chart space views

<img width="1251" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/0ac44f67-44f8-4c98-8c41-960bc7d8015f">

* Fixes #2049

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4365) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4365)
- [Docs
preview](https://rerun.io/preview/071a456269388f0882bd379b0f88f58ccd9912c8/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/071a456269388f0882bd379b0f88f58ccd9912c8/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to hide or move legend in a plot
2 participants