Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional color component to BarChart archetype #4372

Merged
merged 2 commits into from Nov 28, 2023
Merged

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Nov 28, 2023

What

"""Create and log a bar chart."""

import rerun as rr

rr.init("rerun_example_bar_chart", spawn=True)
rr.log("bar_chart", rr.BarChart([8, 4, 0, 9, 1, 4, 1, 6, 9, 0], color=(255, 0, 0)))

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested app.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added the ui concerns graphical user interface label Nov 28, 2023
@jleibs jleibs marked this pull request as ready for review November 28, 2023 16:41
@Wumpf Wumpf self-requested a review November 28, 2023 16:44
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! But you didn't update the cpp & rust examples (this should cause a ci failure!) as well as the doc screenshot

@jleibs
Copy link
Member Author

jleibs commented Nov 28, 2023

nice! But you didn't update the cpp & rust examples (this should cause a ci failure!) as well as the doc screenshot

Oops -- didn't mean to commit the changed example because I didn't want to deal with updating screenshots.

@jleibs jleibs added include in changelog 🍏 primitives Relating to Rerun primitives labels Nov 28, 2023
@jleibs jleibs merged commit a521a06 into main Nov 28, 2023
42 checks passed
@jleibs jleibs deleted the jleibs/color_barchart branch November 28, 2023 17:30
teh-cmc pushed a commit that referenced this pull request Nov 30, 2023
### What
- Resolves: #1355

```
"""Create and log a bar chart."""

import rerun as rr

rr.init("rerun_example_bar_chart", spawn=True)
rr.log("bar_chart", rr.BarChart([8, 4, 0, 9, 1, 4, 1, 6, 9, 0], color=(255, 0, 0)))
```


![image](https://github.com/rerun-io/rerun/assets/3312232/6af1ad96-0683-401c-ac82-3f7cf0ade57d)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4372) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4372)
- [Docs
preview](https://rerun.io/preview/44d44da7cf0e5ce66a48273fdcd24695bf965331/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/44d44da7cf0e5ce66a48273fdcd24695bf965331/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🍏 primitives Relating to Rerun primitives ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set the color for bar charts
2 participants