Refactor naming of SpaceViewClass and changed TextSpaceView name to "Text Log"
#4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tSpaceView` name to "Text Log"
4 tasks
abey79
added
🧑💻 dev experience
Wumpf
reviewed
Nov 29, 2023
abey79
changed the title
SpaceViewClass and ViewSystem and changed TextSpaceView name to "Text Log"SpaceViewClass and changed TextSpaceView name to "Text Log"
|
I reverted the change on |
# Conflicts: # crates/re_viewer/src/ui/selection_panel.rs # crates/re_viewport/src/space_view.rs
Wumpf
approved these changes
Nov 29, 2023
teh-cmc
pushed a commit
that referenced
this pull request
Nov 30, 2023
…to "Text Log" (#4386) ### What Space View names are now user-facing, so I wanted to change "TextLog" to "Text Log", consistent with all other multi-word space view names. In the process, I ended up refactoring the way names is handled for `SpaceViewClass`s ~~and `ViewSystem`s~~, such that they all provide a convenient `ClassName::NAME` constant to use throughout the code. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4386) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4386) - [Docs preview](https://rerun.io/preview/700b50bc390cb857067a2f3242f4225dffe08e5d/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/700b50bc390cb857067a2f3242f4225dffe08e5d/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Space View names are now user-facing, so I wanted to change "TextLog" to "Text Log", consistent with all other multi-word space view names. In the process, I ended up refactoring the way names is handled for
SpaceViewClasssand, such that they all provide a convenientViewSystemsClassName::NAMEconstant to use throughout the code.Checklist