Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderContext usage cleanup #4446

Merged
merged 2 commits into from Dec 6, 2023
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 6, 2023

What

Some cleanup related to recent interior mutability changes: In a lot of places we can now pass just the RenderContext instead of several arguments, making a lot of code less complex. Also, "shared renderer data" is no longer needed either and is flattened out into the RenderContext.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality include in changelog labels Dec 6, 2023
@Wumpf Wumpf force-pushed the andreas/re_renderer/ctx-passing-cleanup branch from c658527 to 032f676 Compare December 6, 2023 13:24
@emilk emilk self-requested a review December 6, 2023 13:25
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer

@Wumpf Wumpf merged commit fa25e53 into main Dec 6, 2023
40 checks passed
@Wumpf Wumpf deleted the andreas/re_renderer/ctx-passing-cleanup branch December 6, 2023 14:38
@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🔺 re_renderer affects re_renderer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants