Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate re_tensor_ops crate into re_space_view_tensor #4450

Merged
merged 3 commits into from Dec 7, 2023
Merged

Integrate re_tensor_ops crate into re_space_view_tensor #4450

merged 3 commits into from Dec 7, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 7, 2023 •
edited by github-actions bot

What

That crate was rather pointless as noticed while going through crates.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality include in changelog labels Dec 7, 2023
abey79
abey79 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@Wumpf Wumpf merged commit 93f8522 into main Dec 7, 2023
40 checks passed
@Wumpf Wumpf deleted the andreas/remove-re_tensor_ops branch December 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wumpf @abey79