Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show leading slash when formatting entity paths #4537

Merged
merged 10 commits into from Dec 14, 2023
Merged

Show leading slash when formatting entity paths #4537

merged 10 commits into from Dec 14, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 14, 2023 •
edited by github-actions bot

What

image

…I also decided to refactor the EntityPaths a bit. Sorry.
Best reviewed commit by commit.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added ui concerns graphical user interface include in changelog labels Dec 14, 2023
jleibs
jleibs approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- agree getting rid of the impl indirection makes this clearer overall.

@emilk emilk merged commit 0eaad73 into main Dec 14, 2023
40 checks passed
@emilk emilk deleted the emilk/leading-slash branch December 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @jleibs