Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose wgpu profiling scopes to puffin #4581

Merged
merged 1 commit into from Dec 20, 2023
Merged

Expose wgpu profiling scopes to puffin #4581

merged 1 commit into from Dec 20, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 19, 2023 •
edited

What

image

(only CPU profile scopes though, nothing from GPU)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🔺 re_renderer affects re_renderer itself include in changelog labels Dec 19, 2023
emilk
emilk commented Dec 19, 2023
View reviewed changes
Cargo.lock
]

[[package]]
name = "profiling-procmacros"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency will no longer be needed once aclysma/profiling#61 is merged

@Wumpf Wumpf self-requested a review December 19, 2023 17:00
Wumpf
Wumpf approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool!

@emilk emilk merged commit b6fc4f4 into main Dec 20, 2023
42 of 43 checks passed
@emilk emilk deleted the emilk/wgpu-profiling branch December 20, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf