Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to log segmentation images directly as floats #4585

Merged
merged 2 commits into from Dec 20, 2023
Merged

Make it possible to log segmentation images directly as floats #4585

merged 2 commits into from Dec 20, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Dec 19, 2023 •
edited by github-actions bot

What

This appears to have already worked and was just being prevented by obsolete checks. Also we weren't doing the user-space conversions in C++ or Rust anyways.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself 🐍 Python API Python logging API include in changelog and removed ui concerns graphical user interface labels Dec 19, 2023
@jleibs jleibs marked this pull request as ready for review December 19, 2023 15:30
@Wumpf Wumpf self-requested a review December 19, 2023 16:03
Wumpf
Wumpf approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jleibs jleibs merged commit 42bc02d into main Dec 20, 2023
43 checks passed
@jleibs jleibs deleted the jleibs/float_segmentations branch December 20, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation Images should handle non-integer types in the viewer
2 participants
@jleibs @Wumpf