Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shading with two lights instead of one #4648

Merged
merged 1 commit into from Jan 3, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 3, 2024

Before

The backside of meshes was a uniform gray
shading-before

After

All sides have some shading
shading-after

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🔺 re_renderer affects re_renderer itself include in changelog labels Jan 3, 2024
@emilk emilk merged commit 6ddec7b into main Jan 3, 2024
41 of 43 checks passed
@emilk emilk deleted the emilk/better-shading branch January 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant