Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce container icons and update space views and UI icons #4663

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Jan 3, 2024

What

This PR:

  • introduces icons for containers (tab, vertical, horizontal, grid)
  • introduces icons for space views which missed them
  • update most existing icons
  • cleanup icon names

The new standard is to have 14x14px icons, so the files are stored as 28x28 png.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 3, 2024
@abey79 abey79 merged commit 1457d8b into main Jan 3, 2024
40 checks passed
@abey79 abey79 deleted the antoine/new-icons branch January 3, 2024 20:22
abey79 added a commit that referenced this pull request Jan 15, 2024
### What

#4663 introduced a bunch of new icons, but the container icons were a
tad too busy. This PR introduce the new version from @martenbjork, along
with a couple other minor icon tweaks.

New icons:

<img width="356" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/0fd5def6-3bce-47e0-9472-81211ffd9697">

In the UI:

<img width="155" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/cf0c323d-fcc0-4655-960f-769ce3a80647">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4814/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4814/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4814/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4814)
- [Docs
preview](https://rerun.io/preview/029bfa78e1a698757f9b6483e899838a0038724a/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/029bfa78e1a698757f9b6483e899838a0038724a/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants