Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename StoreDb to EntityDb, re_data_store -> re_entity_db #4670

Merged
merged 4 commits into from Jan 4, 2024
Merged

Rename StoreDb to EntityDb, re_data_store -> re_entity_db #4670

merged 4 commits into from Jan 4, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 4, 2024 •
edited by github-actions bot

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 4, 2024
@emilk emilk changed the title Rename StoreDb to EntityDb Rename StoreDb to EntityDb, re_data_store -> re_entity_db Jan 4, 2024
@Wumpf Wumpf self-requested a review January 4, 2024 10:42
Wumpf
Wumpf approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's merge asap :)

@Wumpf
Copy link
Member

Wumpf commented Jan 4, 2024

https://docs.rs/re_entity_db needs to be a speculative link

@emilk emilk merged commit a284fd6 into main Jan 4, 2024
40 checks passed
@emilk emilk deleted the emilk/rename-store-db branch January 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf