Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for full span highlighting to modal and use it in the "Add Space View or Container" modal #4822

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Add support for full span highlighting to modal and use it in the "Add Space View or Container" modal #4822

merged 7 commits into from
Jan 16, 2024

Commits on Jan 15, 2024

  1. Update the modal to support full span behavior

    @abey79
    abey79 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b18413c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Updated add SV/container modal (but broke add entity modal)

    @abey79
    abey79 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8c2e196 View commit details
    Browse the repository at this point in the history

  2. Add a "full span" mode to modal, such as to not break other modals

    @abey79
    abey79 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    eb7d7e3 View commit details
    Browse the repository at this point in the history

  3. Add an example in re_ui_example with ListItem

    @abey79
    abey79 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f20a4ca View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @abey79
    abey79 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6f4beb2 View commit details
    Browse the repository at this point in the history

  5. Fix some comment

    @abey79
    abey79 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7df50e9 View commit details
    Browse the repository at this point in the history

  6. Addressed review comments + minor cleaning

    @abey79
    abey79 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c76b1a5 View commit details
    Browse the repository at this point in the history