Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for full span highlighting to modal and use it in the "Add Space View or Container" modal #4822

Merged
merged 7 commits into from Jan 16, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Jan 16, 2024

What

This PR does the following:

  • Make sure the modal's clip rect is the same size as the modal itself.
  • Add a full_span_separator() helper function that's similar to ui.separator() but draws a full-span line and doesn't add vertical spacing.
  • Add a "full span" mode to our modal. In this mode, the vertical spacing is entirely left up to the user code.
  • Use the above in the "Add Space View or Container" modal for a nice, full span hover highlighting.
  • Add an example in re_ui_example showcasing how full span modal and ListItem work together.
  • Fixes Improve modal window styling to support full span highlighting #4673

re_ui_example with ListItem:
Export-1705396140814

Add SV or Container:

Export-1705397228282

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 16, 2024
@abey79 abey79 changed the title Add support for full span highlighting to modal and use it in the "Add Space View and Container" modal Add support for full span highlighting to modal and use it in the "Add Space View or Container" modal Jan 16, 2024
@emilk emilk self-requested a review January 16, 2024 13:48
@abey79 abey79 merged commit 6a76436 into main Jan 16, 2024
40 checks passed
@abey79 abey79 deleted the antoine/full-span-modal branch January 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve modal window styling to support full span highlighting
2 participants