Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show download sizes of in the example page #4841

Merged
merged 4 commits into from Jan 17, 2024
Merged

Show download sizes of in the example page #4841

merged 4 commits into from Jan 17, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 17, 2024 •
edited by github-actions bot

What

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added ui concerns graphical user interface include in changelog labels Jan 17, 2024
@abey79 abey79 self-requested a review January 17, 2024 14:39
abey79
abey79 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@emilk emilk merged commit 8e4e232 into main Jan 17, 2024
40 checks passed
@emilk emilk deleted the emilk/example-byte-sizes branch January 17, 2024 14:59
@emilk emilk mentioned this pull request Jan 19, 2024
Merged
4 tasks
emilk added a commit that referenced this pull request Jan 19, 2024
@emilk
Fix panic when failing to load RRD size (#4872)
803cbaf 
### What
* Introduced in #4841

`poll-promise` has a gotcha: if you drop the `Sender` without sending a
result,, the `Promise` will panic when polled.

I opened an issue about this:
EmbarkStudios/poll-promise#25

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4872/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4872/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4872/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4872)
- [Docs
preview](https://rerun.io/preview/bdbdc1f71719e792869be347ebef16bcb318f2dd/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bdbdc1f71719e792869be347ebef16bcb318f2dd/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show size of RRD in the example page
2 participants
@emilk @abey79