Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a TimeSeries archetype and use it to control the plot legend #4867

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jan 18, 2024

What

This is the basic pattern we expect to see for all of these view-configuration type tasks:

  • Add a new archetype / component
  • Add logic to the TimeSeries space-view-class implementation that both reads and writes the components directly from the blueprint store.

This generally seems to be much easier to think about than dealing with the EntityProperties struct as this was handled previously as it's exclusively a contact between the TimeSeries archetype and the TimeSeriesSpaceView implementation.

Open question:

  • Should we suffix all our view archetypes with something like TimeSeriesView?

Needs #4609 to land first since I developed there before rebasing to main.

Will be nice to come back and clean this up again once #3384 is done.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 18, 2024
@jleibs jleibs marked this pull request as ready for review January 18, 2024 22:35
Copy link
Contributor

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but shouldn't the legend stuff be removed from EntityProperties then?

@jleibs
Copy link
Member Author

jleibs commented Jan 19, 2024

LGTM but shouldn't the legend stuff be removed from EntityProperties then?

Still being used separately in the BarChart -- I'll introduce more Archetypes and remove it in a future PR.

@jleibs jleibs force-pushed the jleibs/time_series_archetype branch from f83f446 to d76ed77 Compare January 19, 2024 17:13
@jleibs jleibs merged commit 965d063 into main Jan 19, 2024
43 checks passed
@jleibs jleibs deleted the jleibs/time_series_archetype branch January 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants