Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up plot charts when there's a Clear #4957

Merged
merged 3 commits into from Jan 30, 2024
Merged

Break up plot charts when there's a Clear #4957

merged 3 commits into from Jan 30, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 30, 2024

Integrate plots with the Clear archetype in a useful way.

Before:

24-01-30_10.00.08.patched.mp4

After:

24-01-30_10.24.46.patched.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added ui concerns graphical user interface include in changelog 🔩 data model labels Jan 30, 2024
@Wumpf Wumpf self-requested a review January 30, 2024 09:38
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice! And so simple!

@Wumpf
Copy link
Member

Wumpf commented Jan 30, 2024

We might want to adjust the documentation on Clear

@Wumpf
Copy link
Member

Wumpf commented Jan 30, 2024

I mean it hasn't changed fundmentally, but maybe a note that it can have an effect on time series unlike what it says here 🤔
https://github.com/rerun-io/rerun/blob/main/crates/re_types/definitions/rerun/archetypes/clear.fbs#L18

@Wumpf
Copy link
Member

Wumpf commented Jan 30, 2024

thanks! 👍

@teh-cmc teh-cmc merged commit 5fd5ae9 into main Jan 30, 2024
43 checks passed
@teh-cmc teh-cmc deleted the cmc/plot_breaks branch January 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants