Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style container's label as unnamed #4975

Merged
merged 6 commits into from Jan 31, 2024
Merged

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Jan 30, 2024

What

This PR styles the container label like unnamed space views in the blueprint tree and the children list (container selection panel). It also fixes the UI and behaviour of tiles tabs for container (which typically appear when a tab container's direct child is also a container).

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 marked this pull request as ready for review January 30, 2024 18:02
@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 30, 2024
crates/re_viewport/src/viewport.rs Outdated Show resolved Hide resolved
crates/re_viewport/src/viewport.rs Outdated Show resolved Hide resolved
@abey79 abey79 merged commit a7356ca into main Jan 31, 2024
40 of 41 checks passed
@abey79 abey79 deleted the antoine/container-style-unnamed branch January 31, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style containers in the same way as unnamed space view
2 participants