Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New empty space view defaults to uncollapsed in blueprint tree #4982

Merged
merged 1 commit into from
Jan 31, 2024
Merged

New empty space view defaults to uncollapsed in blueprint tree #4982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/re_viewport/src/viewport_blueprint_ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ impl Viewport<'_, '_> {

let root_node = result_tree.first_interesting_root();

let default_open = root_node.map_or(false, Self::default_open_for_data_result);
// empty space views should display as open by default to highlight the fact that they are empty
let default_open = root_node.map_or(true, Self::default_open_for_data_result);

let collapsing_header_id = ui.id().with(space_view.id);
let is_item_hovered =
Expand Down Expand Up @@ -218,7 +219,7 @@ impl Viewport<'_, '_> {
space_view_visible,
);
} else {
ui.label("No results");
ui.label("No data");
}
});

Expand Down