Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New empty space view defaults to uncollapsed in blueprint tree #4982

Merged
merged 1 commit into from Jan 31, 2024
Merged

New empty space view defaults to uncollapsed in blueprint tree #4982

merged 1 commit into from Jan 31, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Jan 31, 2024 •
edited by Wumpf

What

New empty space view default to open and show "No data" (instead of "No results").

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jan 31, 2024
Wumpf
Wumpf approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. the default open thing could use a facelift overall imho. Rarely does what I want it to do

@Wumpf Wumpf merged commit 1652265 into main Jan 31, 2024
41 of 44 checks passed
@Wumpf Wumpf deleted the antoine/empty-sv-open-no-data branch January 31, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New space views should be displayed uncollapsed in the blueprint tree and with "no data"
2 participants
@abey79 @Wumpf