Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show the LegacyVisualizer if a user logs with TimeSeriesScalar archetype #5023

Merged
merged 1 commit into from Feb 4, 2024
Merged

Only show the LegacyVisualizer if a user logs with TimeSeriesScalar archetype #5023

merged 1 commit into from Feb 4, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 2, 2024 •
edited

What

This avoids showing the LegacyTimeSeries visualizer when a user uses the new Scalar archetype.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added ui concerns graphical user interface include in changelog labels Feb 2, 2024
@jleibs jleibs marked this pull request as ready for review February 2, 2024 16:23
@Wumpf Wumpf self-requested a review February 4, 2024 16:07
Wumpf
Wumpf approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's actually a really nice workaround in this case, great idea! 👍

@Wumpf Wumpf merged commit 5aa27d6 into main Feb 4, 2024
42 of 45 checks passed
@Wumpf Wumpf deleted the jleibs/legacy_only_indicated branch February 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jleibs @Wumpf