Do not allow adding Horizontal/Vertical containers inside of containers with the same type #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs with the same type - Fixes #5082
emilk
approved these changes
Feb 7, 2024
| @@ -70,7 +71,32 @@ fn modal_ui( | |||
| ]; | |||
|
|
|||
| for (title, subtitle, kind) in container_data { | |||
| if row_ui(ui, icon_for_container_kind(&kind), title, subtitle).clicked() { | |||
| let target_container_kind = target_container | |||
There was a problem hiding this comment.
maybe parent_container_kind is more descriptive?
There was a problem hiding this comment.
We have "target_container" all over the place in that file, so I'd keep it as is for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Note: due to emilk/egui#3997, the tooltip shows up immediately, which is slightly annoying.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io