Context Menu 1: Basic scaffolding and simple actions #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
force-pushed
the
antoine/context-menu
branch
from
d9bf94b
to
6379750
Compare
abey79
changed the title
abey79
changed the title
abey79
force-pushed
the
antoine/context-menu
branch
from
75be468
to
6440ed8
Compare
Wumpf
requested changes
Feb 14, 2024
🤦🏻 |
abey79
force-pushed
the
antoine/context-menu
branch
from
9309f41
to
4b5e470
Compare
Wumpf
approved these changes
Feb 15, 2024
|
|
||
| /// Trait for things that can populate a context menu | ||
| trait ContextMenuItem { | ||
| //TODO(ab): should probably return `egui::WidgetText` instead |
There was a problem hiding this comment.
That comment is actually wrong. The end-game is to return a ListItem (with all the fanciness that comes with it: nicer look, icon, etc.). Both ListItem and the egui context menu code needs a bit of a overhaul for this to work though, so it'll come as a follow-up.
| } | ||
|
|
||
| // ================================================================================================ | ||
| // Utility items |
There was a problem hiding this comment.
guess it's a matter of taste but I would have started a subfolder for context menu with modules for each of these item categories
It looks pretty much like this gonna be another thing where one dynamically registers elements, so might as well already structure it like one
There was a problem hiding this comment.
Good point. I'll do that in a follow up PR to avoid too many rebasing annoying with my existing follow-up.
| /// Trait for things that can populate a context menu | ||
| trait ContextMenuItem { | ||
| //TODO(ab): should probably return `egui::WidgetText` instead | ||
| fn label(&self, _ctx: &ViewerContext<'_>, _viewport_blueprint: &ViewportBlueprint) -> String { |
There was a problem hiding this comment.
Just a label is a bit little though? Should add icons in a follow-up pr so we can show the familiar space view and layout icons - they are much faster to parse than text
There was a problem hiding this comment.
Yup—see my other comment.
5 tasks
abey79
added a commit
that referenced
this pull request
Feb 16, 2024
### What * Follow up to #5163 * Part of #4823 <img width="260" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/f911f4ca-a33e-4e7a-85a9-80f126148be4"> <br/> <br/> This PR adds support for multiple selection with context menus in blueprint view. The selection logic is as follows: - If the (right-)clicked item is part of the selection, the context menu actions apply to the entire selection. - Otherwise, the selection is set to the clicked item, and the context menu actions apply to that item only. This PR doesn't introduce any new action, but adjust the existing ones to handle multi-selection: - If only space views and/or containers are selected, the visibility toggle and Remove actions are offered. The visible toggle will offer to show if one or more items are currently hidden, and hide if all are currently visible. If the root container is part of the multi-selection, its is ignored by those actions. - The "Add SV/Container" actions are offered only if exactly one container item is selected. TODO in future PR: - additional actions - entity level manipulations - use ListItem instead of label/WidgetText - better folder structure - release checklist update ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5205/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5205/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5205/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5205) - [Docs preview](https://rerun.io/preview/291a52d41703e7e70f1de7d905754ff6ac46cdcb/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/291a52d41703e7e70f1de7d905754ff6ac46cdcb/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is the first of a series to implement context menus in the Blueprint Tree. Here we setup the basic scaffolding and implement some basic actions:
The selection is currently ignore and the actions only apply to the clicked item. TODO in future PRs:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io