Cached transforms & disconnected spaces for faster scenes with many transforms #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
force-pushed
the
cmc/cached_transform_arrows
branch
from
c108726
to
af01b28
Compare
teh-cmc
force-pushed
the
cmc/cached_transform_arrows
branch
from
af01b28
to
f2d91ac
Compare
teh-cmc
changed the title
|
Let's get rid of those cache stats next 😒 |
|
Oh actually there's still this |
|
Added cached pinholes @Wumpf |
Wumpf
approved these changes
Feb 23, 2024
Wumpf
changed the title
5 tasks
Wumpf
added a commit
that referenced
this pull request
Feb 26, 2024
### What * Missed this one on #5221 Didn't make a big difference in perf though for the scene I tested with (opf --no-frames), but no point in not keeping it, likely more relevant for more even more pinholes. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5271/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5271/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5271/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5271) - [Docs preview](https://rerun.io/preview/d432d0758198ceb81cf950e39543d1c4268bc7e3/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/d432d0758198ceb81cf950e39543d1c4268bc7e3/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to check whether the feature is enabled before querying.
This makes a massive difference in big scenes with large transform hierarchies.
After:
Before:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io