Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spawn starting the viewer even if logging is disabled #5284

Merged
merged 1 commit into from Feb 26, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 26, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working include in changelog 🪵 Log-API Affects the user-facing API for all languages labels Feb 26, 2024
@emilk emilk merged commit 76ded9b into main Feb 26, 2024
43 checks passed
@emilk emilk deleted the andreas/fix-spawn-on-disabled-rerun branch February 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🪵 Log-API Affects the user-facing API for all languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spawn doesn't respect default_enabled(false) and RERUN=0 env var
2 participants