Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable background color for 3D Space Views #5443

Merged
merged 15 commits into from Mar 12, 2024
Merged

Configurable background color for 3D Space Views #5443

merged 15 commits into from Mar 12, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 8, 2024 •
edited by github-actions bot

What

Originally made a sort of tint/alpha color for the existing gradient, but after some feedback I got I changed it around to be a dropdown of 3 different modes: dark gradient, bright gradient, solid color (with the picker)
The blend version was quite confusing and admittedly not all that useful :)

colorpicker2.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added enhancement New feature or request 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI include in changelog labels Mar 8, 2024
emilk
emilk approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

crates/re_space_view_spatial/src/space_view_3d.rs Outdated Show resolved Hide resolved
crates/re_renderer/shader/generic_skybox.wgsl Outdated Show resolved Hide resolved
crates/re_renderer/src/renderer/generic_skybox.rs Outdated Show resolved Hide resolved
crates/re_renderer_examples/depth_cloud.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/space_view_3d.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/space_view_3d.rs
ui.end_row();
}

fn background_color_text(kind: Background3DKind) -> &'static str {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better as impl Display for Background3DKind

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum already implement Display and I didn't want to change codegen just now

crates/re_types/src/components/color_ext.rs Show resolved Hide resolved
crates/re_types/src/blueprint/archetypes/background3d_ext.rs Show resolved Hide resolved
crates/re_types/definitions/rerun/blueprint/components/background_3d_kind.fbs Outdated Show resolved Hide resolved
crates/re_types/definitions/rerun/blueprint/components/background_3d_kind.fbs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Size changes

Name main 5443/merge Change
incremental_logging.rrd 0.0 MiB (deleted) -100%

@Wumpf Wumpf merged commit 7a6efff into main Mar 12, 2024
39 checks passed
@Wumpf Wumpf deleted the andreas/configurable-background-color branch March 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI enhancement New feature or request include in changelog 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable background color for the 3D view
2 participants
@Wumpf @emilk