Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More context menu 7: cleanup #5456

Merged
merged 3 commits into from Mar 12, 2024
Merged

More context menu 7: cleanup #5456

merged 3 commits into from Mar 12, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Mar 11, 2024

What

NOTE: review commit by commit (first commit is pure refactoring).

Final PR in the series. This PR:

  • split actions.rs into many sub-files
  • fix capitalisation in some menu item
  • split the release check list in small checks

Full series:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added 🚜 refactor Change the code, not the functionality 🔨 testing testing and benchmarks include in changelog labels Mar 11, 2024
@Wumpf Wumpf self-requested a review March 11, 2024 12:56
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blindly trusting the first commit ;)

that's still a loot of manual checks there, but at least more atomic 👍

@abey79
Copy link
Contributor Author

abey79 commented Mar 12, 2024

that's still a loot of manual checks there, but at least more atomic 👍

Agreed. Hopefully, most of that can be automated with the test harness :)

@abey79 abey79 merged commit 2af4da0 into main Mar 12, 2024
34 of 39 checks passed
@abey79 abey79 deleted the antoine/mcm7-cleanup branch March 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚜 refactor Change the code, not the functionality 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants