Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save blueprint to file #5491

Merged
merged 5 commits into from Mar 13, 2024
Merged

Save blueprint to file #5491

merged 5 commits into from Mar 13, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 13, 2024 •
edited by github-actions bot

What

This adds a command for saving the currently active .blueprint file to disk.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Mar 13, 2024
@emilk emilk changed the title Emilk/save blueprint Save blueprint to file Mar 13, 2024
jleibs
jleibs approved these changes Mar 13, 2024
View reviewed changes
crates/re_viewer/src/store_hub.rs
.entry(app_id.clone())
.or_insert_with(|| StoreId::from_string(StoreKind::Blueprint, app_id.clone().0))
});
let app_id = self.selected_application_id.clone()?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner 😍 !

@jleibs
Copy link
Member

jleibs commented Mar 13, 2024

I know we didn't like .blueprint but we never came up with a better file extension 🤔

@emilk
Copy link
Member Author

emilk commented Mar 13, 2024

We'll change .blueprint to something else in a separate PR

@emilk emilk merged commit e4f1fc9 into main Mar 13, 2024
34 checks passed
@emilk emilk deleted the emilk/save-blueprint branch March 13, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @jleibs