Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically expand and scroll the streams tree when focusing on an item #5494

Merged
merged 9 commits into from Mar 18, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Mar 13, 2024

What

This PR adds support for expanding and scrolling to the focus item in the Streams view. It also adds expanding/scrolling the Blueprint tree when focusing on a component.

TODO:

  •  update egui commit once ☝🏻 is merged
focus_scroll_works.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc self-requested a review March 14, 2024 07:57
@teh-cmc
Copy link
Member

teh-cmc commented Mar 14, 2024

There seem to be issues with the visibility check.

Example here where the time panel won't scroll even though I cannot see the entity:

24-03-14_09.04.15.patched.mp4

(Also I cannot help but notice that there's no selection highlight in the time panel -- wasn't that implemented? I lost track of all the improvements!)

@abey79
Copy link
Contributor Author

abey79 commented Mar 14, 2024

@teh-cmc yeah sorry, this should be marked as draft. There is a bug going on here that I haven't been able to track so far.

Edit: fixed.

And yeah, "sister-selection" is still on the todo list. It will make that focus feature much nicer.

@abey79 abey79 marked this pull request as draft March 14, 2024 08:08
@abey79 abey79 marked this pull request as ready for review March 15, 2024 15:51
@abey79 abey79 added ui concerns graphical user interface include in changelog do-not-merge Do not merge this PR labels Mar 15, 2024
@abey79 abey79 removed the do-not-merge Do not merge this PR label Mar 18, 2024
# Conflicts:
#	Cargo.lock
#	Cargo.toml
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice

@abey79 abey79 merged commit 300d82a into main Mar 18, 2024
34 checks passed
@abey79 abey79 deleted the antoine/focus-item-streams branch March 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-clicking an entity/instance/component anywhere should put it and its ancestors into focus _everywhere_
2 participants