Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Github's Ubuntu image getting spurious Asan failures #5557

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 18, 2024

What

Hitting some spurious asan issues on ci: Some Linux runs end up spamming AddressSanitizer:DEADLYSIGNAL indefinitely with no additional information.

Originally I suspected this came from

But it's actually a Github image issue, see actions/runner-images#9491

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🦟 regression A thing that used to work in an earlier release 🌊 C++ API C or C++ logging API exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Mar 18, 2024
@Wumpf Wumpf marked this pull request as draft March 18, 2024 12:27
@Wumpf
Copy link
Member Author

Wumpf commented Mar 18, 2024

@Wumpf
Copy link
Member Author

Wumpf commented Mar 18, 2024

Looks like explicitly disabling worked. Triggering two more manual runs to confirm.

The other changes are a net improvement I think, so keeping them

@Wumpf Wumpf closed this Mar 18, 2024
@Wumpf Wumpf reopened this Mar 18, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Mar 18, 2024

@Wumpf Wumpf marked this pull request as ready for review March 18, 2024 13:24
@Wumpf Wumpf marked this pull request as draft March 18, 2024 13:35
@Wumpf Wumpf force-pushed the andreas/cpp-asan-fix-attempt branch 3 times, most recently from 48df48f to f7894e7 Compare March 18, 2024 14:04
@Wumpf
Copy link
Member Author

Wumpf commented Mar 18, 2024

disabling ASAN for the changed functions doesn't get us any further it seems.

@Wumpf Wumpf changed the title Use explicit cast on forwarding in an attempt to make asan happier Workaround for Github's Ubuntu image getting spurious Asan failures Mar 18, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Mar 18, 2024

@Wumpf Wumpf marked this pull request as ready for review March 18, 2024 15:15
@Wumpf Wumpf force-pushed the andreas/cpp-asan-fix-attempt branch from 051dd08 to 8ac1180 Compare March 18, 2024 15:18
@Wumpf Wumpf merged commit 766c474 into main Mar 18, 2024
29 checks passed
@Wumpf Wumpf deleted the andreas/cpp-asan-fix-attempt branch March 18, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C or C++ logging API exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants