Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow creating 3D space views for pinhole-only 3D scenes #5563

Merged
merged 1 commit into from Mar 19, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 18, 2024

What

python /Users/andreas/dev/rerun-io/rerun/docs/snippets/all/pinhole_simple.py

Before (0.14):
image

After:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release include in changelog labels Mar 18, 2024
@Wumpf Wumpf merged commit 4d2a8b9 into main Mar 19, 2024
37 of 39 checks passed
@Wumpf Wumpf deleted the andreas/heuristic-fixes-3d branch March 19, 2024 08:08
@emilk emilk changed the title Fix not creating 3D space views for pinhole-only 3D scenes Fix: allow creating 3D space views for pinhole-only 3D scenes Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinhole with single image no longer creates a 3D view
2 participants