Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include blueprint in an .rrd when calling .save(…) #5572

Merged
merged 10 commits into from Mar 21, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 19, 2024

What

This adds an optional blueprint argument to rr.save which if provided, will end up first in the written .rrd file.

When using rr.script_setup (like all our examples do) with a blueprint, --save will put that blueprint in the .rrd file.

This should mean that the examples build by CI will include blueprints.

BONUS: this also adds the blueprint to rr.serve and rr.stdout (and --serve/--stdout in our examples).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

Copy link

Size changes

Name main 5572/merge Change
plots.rrd 0.16 MiB 0.17 MiB +6.25%

examples/python/structure_from_motion/main.py Outdated Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/sinks.py Outdated Show resolved Hide resolved
@emilk emilk merged commit dc46941 into main Mar 21, 2024
34 checks passed
@emilk emilk deleted the emilk/blueprint-on-save branch March 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export blueprints for examples and load them from the viewer
2 participants