Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth cloud bounding boxes for depth cloud visualizations with transforms #5578

Merged
merged 1 commit into from Mar 20, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 19, 2024

What

Bounding box was accidentally transformed twice!
Noticed by @roym899 - bounding boxes for depth clouds are still not perfect since they take the bounding box of the full theoretical frustum and not the points displayed, but it's a lot better

Before:
image

After:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Mar 19, 2024
@@ -168,7 +168,7 @@ pub struct DepthCloud {

impl DepthCloud {
/// World-space bounding-box.
pub fn bbox(&self) -> macaw::BoundingBox {
pub fn world_space_bbox(&self) -> macaw::BoundingBox {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Wumpf Wumpf merged commit aba8fca into main Mar 20, 2024
37 checks passed
@Wumpf Wumpf deleted the andreas/fix-depth-cloud-boundingbox branch March 20, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants