Fix image view not handling images with extra leading dimensions of size 1
#5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
Wumpf
force-pushed
the
andreas/fix-handling-image-with-trailing-dimensions
branch
from
f03d53a
to
7908413
Compare
teh-cmc
approved these changes
Mar 20, 2024
### What This was a tough one! But I'm somewhat happy with how this looks now.  For comparision, this is a social media post we did with this demo at some point. It had a different aspect ratio though which is why I diverged from this quite a bit https://www.linkedin.com/posts/nikolauswest_visualizing-depth-guided-stable-diffusion-activity-7011344379873234945-IFS7/?trk=public_profile_like_view ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5582/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5582/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5582/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5582) - [Docs preview](https://rerun.io/preview/f3c0af0de4cf5cb54526428cf4aaaa6c23f2c91b/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/f3c0af0de4cf5cb54526428cf4aaaa6c23f2c91b/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Wumpf
force-pushed
the
andreas/fix-handling-image-with-trailing-dimensions
branch
2 times, most recently
from
4f4903a
to
ce7eab6
Compare
emilk
changed the title
1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Encountered this while inspecting the
depth_guided_stable_diffusionexample:Before: Nothing shown for a depth image with dimensions
1x1x64x96After:
Note that the changed
shape_shortis only used forimage_height_width_channels.Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io