Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow naming space view containers #5626

Merged
merged 8 commits into from Mar 21, 2024
Merged

Allow naming space view containers #5626

merged 8 commits into from Mar 21, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Mar 21, 2024

What

As the title say ☝🏻

Decisions:

  • Keep "Viewport" in the name of the root container (see screenshot below).
  • Refactor some stuff:
    • moved Contents to re_viewer_contex (I actually been meaning to do that for a while but can't remember why now)
    • moved/renamed SpaceViewName to ContentsName in re_viewer_context

⚠️ review commit by commit

container-names.mp4
import rerun as rr
import rerun.blueprint as rrb

rr.init(
    "rerun_example_demo",
    blueprint=rrb.Horizontal(
        rrb.Vertical(
            rrb.Spatial3DView(origin="/point3d"),
            rrb.Spatial3DView(origin="/point3d"),
            name="First Vertical",
        ),
        rrb.Vertical(
            rrb.Spatial3DView(origin="/point3d"),
            rrb.Spatial3DView(origin="/point3d"),
            name="Second Vertical",
        ),
        name="Top-Level",
    ),
)
rr.connect()

rr.log("point3d", rr.Points3D([0, 1, 2]))
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added 🐍 Python API Python logging API ui concerns graphical user interface include in changelog labels Mar 21, 2024
@Wumpf Wumpf added the 🟦 blueprint The data that defines our UI label Mar 21, 2024
@abey79 abey79 marked this pull request as ready for review March 21, 2024 16:03
Copy link

github-actions bot commented Mar 21, 2024

Size changes

Name main 5626/merge Change
rrt-star.rrd 5.77 MiB 1.60 MiB -72.27%

@abey79 abey79 merged commit 76fd4cb into main Mar 21, 2024
34 of 35 checks passed
@abey79 abey79 deleted the antoine/container-names branch March 21, 2024 20:11
@emilk emilk changed the title Allow setting custom names to container Allow naming space view containers Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog 🐍 Python API Python logging API ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants