Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent in how items are removed from selection #5643

Merged
merged 1 commit into from Mar 22, 2024
Merged

Be consistent in how items are removed from selection #5643

merged 1 commit into from Mar 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 22, 2024 •
edited

What

This was done in various places and somewhat inconsistently. This change unifies selection & history purging as well as selection fallback.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf
Remove all removed items from selection upon removal
9f723b5 
This was done in various places and somewhat inconsistently. This change unifies selection & history purging as well as selection fallback.
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Mar 22, 2024
@github-actions GitHub Actions
Copy link

Size changes

Name main 5643/merge Change
rrt-star.rrd 11.82 MiB 1.43 MiB -87.90%

emilk
emilk approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Wumpf Wumpf merged commit 84d19d1 into main Mar 22, 2024
34 of 38 checks passed
@Wumpf Wumpf deleted the andreas/fix-remove-not-deselecting branch March 22, 2024 12:39
@emilk emilk changed the title Remove items from selection upon removal consistently Be consistent in how items are removed from selection Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected selection panel UI when removing an entity
2 participants
@Wumpf @emilk