Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selecting data sources and blueprints and recordings in them #5646

Merged
merged 21 commits into from Mar 25, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 22, 2024

What

If you click a recording you will now see what blueprints are in the same data source.
You can also select the data source directly to see all recordings and blueprints in it.
Selecting a blueprint is now also possible.
I also added the size of the store to the selection panel.

select-data-source.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added ui concerns graphical user interface include in changelog labels Mar 22, 2024
@rerun-io rerun-io deleted a comment from github-actions bot Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

Size changes

Name main 5646/merge Change
rrt-star.rrd 2.24 MiB 11.60 MiB +417.86%

@Wumpf Wumpf self-requested a review March 22, 2024 15:37
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!
I'm still pondering if some of this should go behind a feature flag to protect users from strange / undocumented behavior, but I'm leaning more and more towards this being a net improvent regardless and that there's no point in gating it.

The very unrelated default legend needs fixing / roll-back

crates/re_space_view_time_series/src/space_view_class.rs Outdated Show resolved Hide resolved
crates/re_data_ui/src/entity_db.rs Outdated Show resolved Hide resolved
crates/re_data_ui/src/item_ui.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 7e1bde9 into main Mar 25, 2024
34 checks passed
@emilk emilk deleted the emilk/better-store-selection-view branch March 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants