Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken 2D space view heuristics in Python Notebooks #5674

Merged
merged 4 commits into from Mar 26, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 25, 2024

What

could in theory affect also non-notebooks, but practically in only manifested there.
Fixes a few typos I encountered on the way and added a new pixi command for building the rerun webviewer wasm.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Mar 25, 2024
@Wumpf Wumpf force-pushed the andreas/fix-nondeterministic-2d-spaceviews branch from e456e88 to b8ac371 Compare March 25, 2024 16:47
@Wumpf Wumpf force-pushed the andreas/fix-nondeterministic-2d-spaceviews branch from b8ac371 to 618e009 Compare March 25, 2024 16:47
Copy link

Size changes

Name main 5674/merge Change
rrt-star.rrd 8.16 MiB 6.73 MiB -17.52%

@Wumpf Wumpf merged commit 4280fd4 into main Mar 26, 2024
18 of 22 checks passed
@Wumpf Wumpf deleted the andreas/fix-nondeterministic-2d-spaceviews branch March 26, 2024 08:36
@emilk emilk changed the title Fix broken 2D Space View heuristics in Python Notebooks Fix broken 2D space view heuristics in Python Notebooks Apr 5, 2024
@emilk emilk added the notebook Jupyter notebooks etc label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog notebook Jupyter notebooks etc 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial heuristics are broken when when run inside a notebook
3 participants