Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h2 to 0.3.26 to address RUSTSEC-2024-0332 #5775

Merged
merged 1 commit into from Apr 4, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 4, 2024

What

addresses

    = ID: RUSTSEC-2024-0332
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0332
    = An attacker can send a flood of CONTINUATION frames, causing `h2` to process them indefinitely.
      This results in an increase in CPU usage.

      Tokio task budget helps prevent this from a complete denial-of-service, as the server can still
      respond to legitimate requests, albeit with increased latency.

      More details at "https://seanmonstar.com/blog/hyper-http2-continuation-flood/.

as flagged by cargo deny

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added dependencies concerning crates, pip packages etc include in changelog labels Apr 4, 2024
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should by updated in the cargo.toml directly too

@Wumpf
Copy link
Member Author

Wumpf commented Apr 4, 2024

@teh-cmc what would that look like exactly? We don't depend on h2 directly :/

@emilk emilk merged commit a5df691 into main Apr 4, 2024
33 checks passed
@emilk emilk deleted the andreas/update-h2 branch April 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants