Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser back-button navigation #5791

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 4, 2024

What

Loading an example and pressing back will keep the example loaded, but still get you back to the welcome screen.

Loading the example again will clear the old first before continuing.

You can open examples in a background tab by holding down a modifier or middle-clicking.

And fixed small annoyance that required an extra "Back" press to get back to the original source.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🕸️ web regarding running the viewer in a browser exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 4, 2024
@jprochazk
Copy link
Member

Can we also make this work with mouse 4 and mouse 5?

@emilk
Copy link
Member Author

emilk commented Apr 4, 2024

@jprochazk Sure, try out #5792 (I don't have a mouse)

@emilk emilk merged commit 211b9f2 into main Apr 4, 2024
37 of 38 checks passed
@emilk emilk deleted the emilk/improve-back-button branch April 4, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants