Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve UI when viewing all components of an entity #5831

Merged
merged 3 commits into from Apr 8, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 7, 2024

What

Before

image Screenshot 2024-04-07 at 16 58 57

After

Screenshot 2024-04-07 at 17 01 59 Screenshot 2024-04-07 at 17 02 05

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 7, 2024
@emilk emilk merged commit b6b5e28 into main Apr 8, 2024
39 checks passed
@emilk emilk deleted the emilk/improve-instance-key-ui branch April 8, 2024 07:28
emilk added a commit that referenced this pull request Apr 8, 2024
### What
#### Before
<img width="310" alt="image"
src="https://github.com/rerun-io/rerun/assets/1148717/d4cae3cd-171a-4eaa-967e-d35a228c87eb">

<img width="239" alt="Screenshot 2024-04-07 at 16 58 57"
src="https://github.com/rerun-io/rerun/assets/1148717/228f25a6-22af-48f3-aea1-12e451e82b41">


#### After

<img width="338" alt="Screenshot 2024-04-07 at 17 01 59"
src="https://github.com/rerun-io/rerun/assets/1148717/6ca042a4-3f71-4d46-8555-dd22c30d6cfb">


<img width="339" alt="Screenshot 2024-04-07 at 17 02 05"
src="https://github.com/rerun-io/rerun/assets/1148717/6a6bc327-6445-4820-a180-f8860da93671">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5831)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5831?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5831?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5831)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants