Introduce a snippet for Spatial3DView and fix issues related to _RERUN_TEST_FORCE_SAVE #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
🟦 blueprint
jleibs
changed the title
5 tasks
emilk
reviewed
Apr 26, 2024
| @@ -13,6 +13,7 @@ log_line = [ # Not a complete example -- just a single log line | |||
| "rust", | |||
| "py", | |||
| ] | |||
| spatial3dview = ["cpp", "rust"] # Missing examples | |||
There was a problem hiding this comment.
think we should put all space view snippets into their own folder. That way we can easily add checks like "Make sure all spaceviews has a snippet". As is, we can't even do that as an eye-ball check (i.e. answer the question "which space views have we added snippets for?")
emilk
approved these changes
Apr 26, 2024
This was referenced Apr 26, 2024
jleibs
changed the title
jleibs
added a commit
that referenced
this pull request
Apr 26, 2024
### What - Builds on top of: #6120 - Rebase after merging and then remove `do-no-merge` label. Add blueprint views to the python docs index. Create a reference page for each view with documentation of its view properties and an example when provided. Generating pages for all the blueprint archetypes and cross-linking still felt a bit overwhelming. Since these properties are almost always only used in the context of the view, I decided to inline instead. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6121?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6121?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6121) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It turned out that _RERUN_TEST_FORCE_SAVE is totally broken when using blueprints since the blueprint stream stomps on the recording.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.