Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: re_sdk no longer depends on rustls #6210

Merged
merged 5 commits into from May 3, 2024
Merged

Fix: re_sdk no longer depends on rustls #6210

merged 5 commits into from May 3, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 3, 2024

Split out parts of re_data_source to a new crate re_data_loader. This makes the dependency list of re_sdk much lighter.

scripts/ci/count_dependencies.py -p re_sdk --all-features goes from 204 -> 185 dependencies.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

This makes the dependency list of re_sdk much lighter
@emilk emilk added 🚜 refactor Change the code, not the functionality include in changelog labels May 3, 2024
@emilk emilk changed the title Split out parts of re_data_source to re_data_loader Fix: re_sdk no longer depends on rustls May 3, 2024
@emilk emilk marked this pull request as ready for review May 3, 2024 09:55
@teh-cmc teh-cmc self-requested a review May 3, 2024 10:40
@emilk emilk merged commit c667644 into main May 3, 2024
34 checks passed
@emilk emilk deleted the emilk/re_data_loader branch May 3, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re_sdk should not depend on ehttp
2 participants