Allow resetting view property components from gui for all generically implemented property ui #6417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
approved these changes
May 23, 2024
Wumpf
force-pushed
the
andreas/generic-view-property-reset-buttons
branch
from
05223ea
to
2525b4a
Compare
jleibs
approved these changes
May 27, 2024
| ui.close_menu(); | ||
| } | ||
| ui.add_enabled_ui(component_results.contains_non_empty(*component_name), |ui| { | ||
| if ui.button("Reset to empty.") |
There was a problem hiding this comment.
Nit: we need a better name for this
There was a problem hiding this comment.
agreed, but don't know what to pick :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See title :)
This allows to reset the value either to the default blueprint or - via context menu - to empty!
Screen.Recording.2024-05-23.at.17.09.04.mov
Future work:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.