Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve component order in codegened component list #6468

Merged
merged 1 commit into from
May 31, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 31, 2024

What

... at least within required/recommended/requried blocks.
This fixes an ordering issue in (upcoming) generic ui, but has no effect on existing ones yet, making this part of

(pictures from a not pr'ed branch)

Before:
image

After:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 31, 2024
@Wumpf Wumpf merged commit aea3435 into main May 31, 2024
36 checks passed
@Wumpf Wumpf deleted the andreas/preserve-component-list-order-codegen branch May 31, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants