Background color settings uses new generic ui now #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📺 re_viewer
Deployed docs
|
jleibs
approved these changes
Jun 3, 2024
| fn fallback_for(&self, ctx: &re_viewer_context::QueryContext<'_>) -> Color { | ||
| // Color is a fairly common component, make sure this is the right context. | ||
| if ctx.archetype_name == Some(Background::name()) { | ||
| Color::WHITE |
There was a problem hiding this comment.
Is there a reason our 3D views default to white but our 2D views default to black?
There was a problem hiding this comment.
yes, that was an expressed preference by some folks at some point
Wumpf
force-pushed
the
andreas/generic-background-ui2
branch
from
94c2c73
to
b8bdc66
Compare
Wumpf
force-pushed
the
andreas/generic-background-ui2
branch
from
b8bdc66
to
4e05c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
First practical use of automatic fallbacks for view properties that is applied both on query & ui: Query for
backgroundnow goes through the newViewPropertyutility, ui now renders with the generic view property ui method.Note how the system picks the right defaults depending on the context despite this being the same archetype:
https://github.com/rerun-io/rerun/assets/1220815/1f072048-937a-4721-b526-7bed9433b61b
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.