Use egui's UiStack to implement full span widgets
#6491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Jun 4, 2024
|
|
||
| /// Retrieve the current full-span scope. | ||
| fn get_full_span(&self) -> egui::Rangef { | ||
| for node in self.ui().stack().iter() { |
There was a problem hiding this comment.
oh I see, amazing that we can do that now
5 tasks
emilk
pushed a commit
that referenced
this pull request
Jun 5, 2024
### What When #6491 migrated to using `UiStack` for full span scopes, it wasn't possible to manually set a full span scope somewhere. Because of that, a clip rect hack was used for the streams tree. With emilk/egui#4617, it's now possible to support that correctly, so this PR introduces `UiExt::full_span_scope()` and uses it for the streams tree. This PR also bumps the egui/egui_commonmark/egui_tiles commits. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/{{pr.number}}) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
re_uiUI functions to a trait to be implemented byegui::Ui#4569This PR uses emilk/egui#4588 to replace the
full_spanmechanism, which requires less boilerplate and makes it available in many more places (including tooltips). Theget_full_span()function now lives in aUiextension trait, where the rest ofre_uishould eventually migrate (#4569).This PR also updates egui/egui_tiles/egui_commonmark to the latest commits.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.