Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle switch now becomes blue when ON #6494

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Toggle switch now becomes blue when ON #6494

merged 6 commits into from
Jun 7, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Jun 4, 2024

What

Make it clearer when toggles are ON vs. OFF with some color.

Export-1717515899832

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jun 4, 2024
@Wumpf
Copy link
Member

Wumpf commented Jun 4, 2024

wouldn't it make more sense to grey out the background to the color the radio buttons have for disabled? we only use blue for selected so far

@abey79
Copy link
Contributor Author

abey79 commented Jun 4, 2024

wouldn't it make more sense to grey out the background to the color the radio buttons have for disabled? we only use blue for selected so far

Tried this first and it looks bad. Lacks contrast and looks disabled when off.

@emilk
Copy link
Member

emilk commented Jun 5, 2024

We could also try making the circle larger when on

@abey79
Copy link
Contributor Author

abey79 commented Jun 6, 2024

The blue circle is now larger. A net improvement imo.

Export-1717660021692

@abey79 abey79 merged commit fdf659e into main Jun 7, 2024
34 of 35 checks passed
@abey79 abey79 deleted the antoine/better-toggle branch June 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants