Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query-time clears (latest-at only) #6586

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jun 17, 2024

Resolves pending clears at query time, rather than through write cascades.

Only works for latest-at queries for now. We'll take care of range queries once the deserialization cache has been removed, it's just not worth dealing with all the extra complexity at the moment.
The only visible change for users is that the "scalar plot hole" feature doesn't work anymore.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself do-not-merge Do not merge this PR include in changelog 🔩 data model labels Jun 17, 2024
@teh-cmc teh-cmc changed the title Query-time clears Query-time clears (latest-at only) Jun 17, 2024
@teh-cmc teh-cmc marked this pull request as ready for review June 18, 2024 09:00
@jleibs jleibs self-requested a review June 19, 2024 12:07
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprisingly straight forward at this point relative to the pending-clear complexity we've been carrying for the last 18 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model do-not-merge Do not merge this PR include in changelog ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself
Projects
None yet
2 participants