Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select single objects directly and click through selection #964

Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 27, 2023

Centralizes how we compute instance hashes for picking!

We now ...

  • if single instance always click/hover object path
  • if multi instance click/hover object path
  • if multi instance with anything under that object marked in any way as selected, click/hover concrete instance
Screen.Recording.2023-01-27.at.17.01.44.mov

The thing that sparked this: Can now select camera and directly manipulate image plane with less clicks:

Screen.Recording.2023-01-27.at.17.23.14.mov

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

…location now.

Use instance path only when an object already has a selection highlight
@Wumpf Wumpf mentioned this pull request Jan 27, 2023
3 tasks
@emilk
Copy link
Member

emilk commented Jan 27, 2023

So clicking once selects all instances, clicking again selects a single instance? How does that work with double-click?

EDIT: tested it, and double-clicking a point-cloud will select a single point and focus on it. It's fine.

Overall I like this interaction mode. Let's try it out for a few days and see how it feels.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

crates/re_data_store/src/instance.rs Outdated Show resolved Hide resolved
crates/re_query/src/entity_view.rs Outdated Show resolved Hide resolved
crates/re_query/src/entity_view.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/misc/selection_state.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit e111a43 into main Jan 28, 2023
@Wumpf Wumpf deleted the andreas/select-single-objects-directly-and-click-through-selection branch January 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants